unix/gtk.c: Make Prima's child process robust against signals#141
Merged
unix/gtk.c: Make Prima's child process robust against signals#141
Conversation
Signals sent to the application propagate to the whole process group. If a Prima application handles / ignores a signal, the same signal can kill the child, which (correctly) discards any signal handlers set by the application. The patch puts the child in its own process group so that it does no longer receive signals sent to the parent process. This came up in a discussion on PDL: PDLPorters/pdl#492
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signals sent to the application propagate to the whole process group. If a Prima application handles / ignores a signal, the same signal can kill the child, which (correctly) discards any signal handlers set by the application.
The patch puts the child in its own process group so that it does no longer receive signals sent to the parent process.
This came up in a discussion on PDL: PDLPorters/pdl#492